Repository navigation
Conversation
hCoureau
marked this pull request as ready for review
November 11, 2026 19:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
get_clean_recordreceives[]or[[]], indexing the empty list raisesIndexErroroutside the public parsing-exception boundary. Reject the empty record withValueErrorso callers receiveRoborockParsingExceptionwith the original command and payload context.Add public-trait regressions for both empty shapes and compatibility cases for wrapped dictionaries and multi-phase replies. The tests use simulated responses; the six records I captured from my Qrevo 2 Pro were nonempty. Multi-phase aggregation behavior is a separate existing issue.
Validation: 2,283 tests passed on each of Python 3.11 and 3.14; pre-commit, commitlint and source/wheel builds passed. The three bug fixes combined with #1028–#1030 pass 2,310 tests on each Python version.
Related to #1018.